Epik Portfolio

Homepage › Community Forums › Epik Theme Support › Epik Portfolio

Tagged: 

Viewing 9 posts - 1 through 9 (of 9 total)
  • Author
    Posts
  • August 10, 2013 at 3:15 pm #6389
    David Chu
    Customer

      Hi Wes!
      In your post about Genesis 2 compatibility, you mentioned Gary in reference to an Epik portfolio issue.

      That got me curious, so I took a look. I followed the tutorial directions for setting up the Portfolio. I was unable to get the lightbox to come up. So I hunted for a bit, and found code involving that. I noticed that the code to invoke the PrettyPhoto in page_portfolio.php was commented out. I uncommented it, and then the lightbox came right up just great!

      I also noted that there was code right nearby to display the featured image, and so now both the lightbox thumbnail AND the featured thumbnail were appearing… duplication! So I just commented out the featured image code, and voila, a lightbox that worked and no thumbnail duplication!

      btw, the same thing happened whether I was running Genesis 2 or Genesis 1.9, so this was not a Genesis 2 issue per se. Maybe you and Gary are investigating another issue.

      Hope this helps! I also saw one other little peculiarity on the Portfolio page that was not causing it to fail. If you’re interested, please let me know and I’ll share.

      Best, Dave

      August 10, 2013 at 3:28 pm #6391
      David Chu
      Customer

        Hi Again!
        One more thing… in the above code for displaying the PrettyPhotos, I found and fixed one more issue.

        As I’d mentioned, I noticed that the lightbox was working. Then I looked at its own little navigation thumbnails at the bottom. There were tiny thumbnails for the Posts with Featured Images, and also “blank” thumbnails for the “other images”. When I clicked the “other images”, a lightbox error came up saying “image not found”.

        I realized what was going on, and then made the lightbox code conditional – I just used an IF statement to make sure there was an existing featured image before adding a mini-thumbnail. This way, I only got mini-thumbnails on the lightbox for “real images”. 🙂

        Cheers, Dave

        August 10, 2013 at 10:18 pm #6412
        Eric
        Customer

          Yes that’s the way it’s supposed to work, by uncommenting the prettyPhoto code and commenting out the other image code. He did it this way to give options in case people did or didn’t want to use prettyPhoto.

          I create awesome sites for awesome people! Contact me if interested – ericsanchez1585@gmail.com

          August 10, 2013 at 10:36 pm #6414
          Eric
          Customer

            What code did you use for the conditional? I want to test it on a local install.

            I create awesome sites for awesome people! Contact me if interested – ericsanchez1585@gmail.com

            August 11, 2013 at 3:22 pm #6447
            David Chu
            Customer

              I see. And I did notice after the fact that there are separate instructions about the PrettyPhoto setup. I wouldn’t have needed to explore if the default in the template had been to use PrettyPhoto, like the demo. Maybe most people don’t want PrettyPhoto. In any case, it’s good to know that it works, and to familiarize myself with the template code.

              Anyway, having a conditional for the mini-thumbnails is good if you don’t want to force the user to have a Featured Image on every item in the Portfolio. It’s very normal code for this type of context:

              if ( has_post_thumbnail() )   {
    ... other code here ....
}

              Dave

              August 11, 2013 at 4:58 pm #6448
              David Chu
              Customer

                I had some downtime today, so just for giggles and practice, I did a quickie Genesis 2.0 conversion of the Epik theme. It came out very well! The Portfolio section was borked, as expected, but I just made a couple of hook changes as per my own article, and they worked. The appearance was a little funky, but I got it looking decent with a few CSS tweaks, and with a few more minutes of CSS polishing, it would look just lovely.

                So I’m looking forward to seeing what the official 2.0 version will be like!

                Dave

                August 15, 2013 at 11:20 am #6556
                David Chu
                Customer

                  Hi Eric and Wes,
                  Just FYI, not urgent – I converted to official 1.3, and it’s looking great! Re: the PrettyPhoto slider, 1.3 created a new issue, and I tracked it down (apart from my fix for the thumbnails above)…

                  3.1 has CSS that gives a blanket treatment to images, for responsiveness, no doubt:

                  img {
	height: auto;
	width: auto; /* IE8 */
}

                  This made PrettyPhoto mini-thumbs look awful and work funny, so I added this CSS which fixed it:

                  .pp_gallery ul a img {
	width: 50px;
}

                  Then again, I may end up abandoning PrettyPhoto anyway, as it’s not responsive. I added some CSS hacks to force it to be a bit responsive, but it just isn’t quite right anyway. Maybe this will help someone. Plenty of nice responsive sliders out there now. 🙂

                  PS: I noticed 1.3 got rid of the admin bar error – nice job!!!! Wish I could be a fly on the wall and see what changes Gary J made. 😉

                  Dave

                  August 15, 2013 at 4:22 pm #6562
                  Eric
                  Customer

                    Yeah that’s the reason why it’s not set as the default. It adjusts, but it’s not good enough. It’s either too small or too large when viewing from a mobile device. Oh well.

                    I create awesome sites for awesome people! Contact me if interested – ericsanchez1585@gmail.com

                    August 15, 2013 at 5:03 pm #6567
                    David Chu
                    Customer

                      Yeah, just like so many plugins, 2 words: Evil Inline Styles. OK, 3 words. 🙂

                    • Author
                      Posts
                    Viewing 9 posts - 1 through 9 (of 9 total)
                    • You must be logged in to reply to this topic.