Regarding the "stray" header.png

Homepage Community Forums General Regarding the "stray" header.png

Viewing 5 posts - 1 through 5 (of 5 total)
  • Author
    Posts
  • #10564
    sliceofscifi
    Customer

      Curiosity at some of the arguing about the stray header.png call that isn’t being found, and with it causing problems with some people’s websites, caused me to go digging. That, and I got a little upset about the attitude one user displayed over in the StudioPress forums about his problems with this while using Epik.

      Anyway, I think I found what’s causing the problem.

      Sure enough, all the Appfinite themes I have, Ally, Epik and Adapt, all have a line that creates a header.png call, easy enough to find when you do a view source:

      <style type="text/css">.site-header { background: url(http://www.example.com/wp-content/themes/adapt/images/header.png) no-repeat !important; }</style>

      But none of the Genesis 2.0 themes generate this, so I did some comparisons, and found what’s causing this difference.

      In functions.php for the Appfinite themes I have, there’s this function:

      // Add support for custom header
      add_theme_support( 'genesis-custom-header', array(
      	'width' => 360,
      	'height' => 164
      ) );

      but in the Genesis 2.0 themes like Magazine Pro, News Pro and the other HTML5 themes, that function call has been changed to this:

      //* Add support for custom header
      add_theme_support( 'custom-header', array(
              'header_image'    => '',
              'header-selector' => '.site-title a',
              'header-text'     => false,
              'height'          => 90,
              'width'           => 260,
      ) );

      I did two tests… first test, I removed the genesis-custom-header call in Ally 1.3 completely, and that stray reference to a non-existent header.png disappeared. Second test, I changed the call to be just custom-header, and again, that header.png reference disappeared.

      It also doesn’t seem to affect the ability to upload a custom header image in the admin area, so maybe this is a function that worked in Genesis 1.9 but was changed in 2.0 and now behaves differently, resulting in this header.png just crashing the party?

      Just trying to help ๐Ÿ™‚

      #10612
      Eric
      Customer

        Thanks ๐Ÿ™‚ That was pretty much what I was trying to explain to him, that it’s WordPress/Genesis (The Framework itself) that handles adding that file. With Genesis 2.0/WP they create a logo.png, so if you had the older version of Genesis and uploaded a logo, then chances are there could be a header.png. I’m using the latest version of WP, Genesis, and Epik and no header.png shows up when I upload a logo. Only a logo.png, and if I remove it, it goes away.

        He went on StudioPress and claimed that he was “attacked” here, but all everyone was trying to do was explain how it works….then he questioned if I knew what I was talking about lol. So glad he’s gone I can’t stand people that won’t admit when their wrong, especially when he KNOWS he was wrong as he admitted it on SP.


        I create awesome sites for awesome people! Contact me if interested โ€“ ericsanchez1585@gmail.com

        #10664
        sliceofscifi
        Customer

          Well, yes and no.

          Yes, it’s because of how Genesis handles the logo image, but technically, the newer versions of the Appfinite themes could have been updated to use “custom-header” instead of “genesis-custom-header”, since SP also moved towards that with the introduction of Genesis 2.0 and their HTML5 Pro themes. Even with the most recent updates of some of their existing xhtml themes back in January, those are still using “genesis-custom-header”, but all of their HTML5 themes now use “custom-header” instead.

          I wouldn’t have chosen to go so far as to insist that’s a bug, and get my blood pressure all out of whack about it (I save that for image handling and CPTs), but there you have it ๐Ÿ™‚

          #10672
          Eric
          Customer

            I wonder if the theme I have is already updated, because it still doesn’t upload a header.png file and I have a few different installs all with the latest version of Epik. I haven’t checked other themes though, since Epik was the theme in question. I’ll double check again to make sure.

            Wes mentioned not too long ago that he has updates for all of his themes, so maybe that’s one of the things that will be changed. Currently SP uses front-page.php for their homepages now, so that’s another thing that should probably get updated as well.

            I’ll send an email to see what all will get changed.


            I create awesome sites for awesome people! Contact me if interested โ€“ ericsanchez1585@gmail.com

            #10679
            sliceofscifi
            Customer

              The old call to “genesis-custom-header” is present in the newest versions of Epik, Ally and Adapt that I have… should all be v1.3, the updated HTML5 versions. I got Ally and Adapt direct, and bought Epik thru StudioPress.

              I think that old call causes the framework to assume that a header.png is present in the child theme, whereas the newer “custom-header” call makes use of the built in header customization in WordPress.

              I did some digging through a lot of the older SP themes I have, and some of the ones I found that came with a header.png are Associate 1.0.1, Corporate 2.0, Manhattan 1.0, Prose 1.5.2, Streamline 2.0.1… all themes that have been around since at least Genesis 1.7, and all ones that have not yet been revamped for Genesis 2.0 and HTML5.

              Gotta love moving into new tech formats and all ๐Ÿ™‚

            Viewing 5 posts - 1 through 5 (of 5 total)
            • The topic ‘Regarding the "stray" header.png’ is closed to new replies.